New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #669

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Nov 8, 2017

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

@ramsey

This comment has been minimized.

Show comment
Hide comment
@ramsey

ramsey Jan 13, 2018

Contributor

Thank you for contributing.

Unfortunately, I made this change in eb25be9 before looking at the open pull requests. I'll be sure not to do that in the future so that I don't steal the credit from others. 😄

Contributor

ramsey commented Jan 13, 2018

Thank you for contributing.

Unfortunately, I made this change in eb25be9 before looking at the open pull requests. I'll be sure not to do that in the future so that I don't steal the credit from others. 😄

@ramsey ramsey closed this Jan 13, 2018

@carusogabriel carusogabriel deleted the carusogabriel:phpunit branch Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment