New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests #674

Merged
merged 1 commit into from Jan 13, 2018

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Dec 6, 2017

I've refactored some tests using:

  • assertArrayHasKey instead of isset function;
  • assertInternalType instead of is_* functions.
@ramsey

This comment has been minimized.

Show comment
Hide comment
@ramsey

ramsey Jan 13, 2018

Contributor

Thank you for your contribution.

Contributor

ramsey commented Jan 13, 2018

Thank you for your contribution.

@ramsey ramsey merged commit 1da4f39 into thephpleague:master Jan 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carusogabriel carusogabriel deleted the carusogabriel:refactoring-tests branch Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment