New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove official project support for HHVM #682

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@ramsey
Contributor

ramsey commented Jan 13, 2018

This PR removes all HHVM testing on Travis CI and removes mention of official support for HHVM from the README.

While our test suite continues to pass on all HHVM versions we test, many other projects have moved away from official support for HHVM, since HHVM no longer maintains feature parity with PHP 7. When league/oauth2-client no longer supports PHP 5.6, we will need to remove support for HHVM anyway, since we'll potentially be using PHP 7+ features that HHVM does not support.

@ramsey ramsey requested a review from shadowhand Jan 13, 2018

@frankdejonge

This comment has been minimized.

Show comment
Hide comment
@frankdejonge

frankdejonge Jun 28, 2018

Member

I've dropped active support for it on all my packages.

Member

frankdejonge commented Jun 28, 2018

I've dropped active support for it on all my packages.

@ramsey ramsey merged commit 31fb941 into thephpleague:master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ramsey ramsey deleted the ramsey:remove-hhvm-support branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment