New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v3 Release #14

Merged
merged 4 commits into from May 26, 2018

Conversation

Projects
None yet
3 participants
@sudiptpa
Copy link
Contributor

sudiptpa commented May 25, 2018

No description provided.

sudiptpa added some commits May 25, 2018

@Orteko

This comment has been minimized.

Copy link

Orteko commented on e6e4268 May 25, 2018

Probably want to revise that to date('Y') + 1, otherwise the tests will fail as soon as the hard-coded month is past :)

@sudiptpa

This comment has been minimized.

Copy link
Contributor Author

sudiptpa commented May 25, 2018

@Orteko having the expiryMonth as 12 should fix it. Changed all of them and tests are still green.

@sudiptpa

This comment has been minimized.

Copy link
Contributor Author

sudiptpa commented May 26, 2018

@delatbabel and @barryvdh review this PR for v3 release.

@barryvdh barryvdh merged commit f1dc0d1 into thephpleague:master May 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@barryvdh

This comment has been minimized.

Copy link
Member

barryvdh commented May 26, 2018

Thanks!

@sudiptpa sudiptpa deleted the sudiptpa:upgrading-v3 branch May 26, 2018

@sudiptpa

This comment has been minimized.

Copy link
Contributor Author

sudiptpa commented May 30, 2018

@barryvdh any chances to tag a new v3.0.0 release soon ?

@barryvdh

This comment has been minimized.

Copy link
Member

barryvdh commented May 30, 2018

Done

@sudiptpa

This comment has been minimized.

Copy link
Contributor Author

sudiptpa commented May 30, 2018

Thanks but should it be v3.0.0 or V3.0.0 ?

@barryvdh

This comment has been minimized.

Copy link
Member

barryvdh commented May 30, 2018

Does it matter?

@sudiptpa

This comment has been minimized.

Copy link
Contributor Author

sudiptpa commented May 30, 2018

Not sure exactly but, i see people doing v3.0.0 normally.

@sudiptpa

This comment has been minimized.

Copy link
Contributor Author

sudiptpa commented May 30, 2018

No problem that all works, just tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment