From 4d35b0070f61f308b6352345a23ee2ddbf042b9f Mon Sep 17 00:00:00 2001 From: Adrien Schaegis Date: Thu, 24 Nov 2016 17:26:01 +0100 Subject: [PATCH 1/4] [FEATURE] Add tax percent to stripe subscriptions --- src/Message/CreateSubscriptionRequest.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Message/CreateSubscriptionRequest.php b/src/Message/CreateSubscriptionRequest.php index 46d208cf..be705429 100644 --- a/src/Message/CreateSubscriptionRequest.php +++ b/src/Message/CreateSubscriptionRequest.php @@ -41,6 +41,11 @@ public function getData() 'plan' => $this->getPlan() ); + + if (isset($this->parameters->has('tax_percent'))) { + $data['tax_percent'] = (float)$this->getParameter('tax_percent'); + } + return $data; } From 20855fdc9f41b9345feb67c93e67b3770d414030 Mon Sep 17 00:00:00 2001 From: Adrien Schaegis Date: Thu, 24 Nov 2016 18:17:50 +0100 Subject: [PATCH 2/4] [UPDATE] Add getter + setter --- src/Message/CreateSubscriptionRequest.php | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/Message/CreateSubscriptionRequest.php b/src/Message/CreateSubscriptionRequest.php index be705429..f7cc12bf 100644 --- a/src/Message/CreateSubscriptionRequest.php +++ b/src/Message/CreateSubscriptionRequest.php @@ -33,6 +33,26 @@ public function setPlan($value) return $this->setParameter('plan', $value); } + /** + * Get the tax percent + * + * @return string + */ + public function getTaxPercent() + { + return $this->getParameter('plan'); + } + + /** + * Set the plan ID + * + * @return CreateSubscriptionRequest provides a fluent interface. + */ + public function setTaxPercent($value) + { + return $this->setParameter('tax_percent', $value); + } + public function getData() { $this->validate('customerReference', 'plan'); From 1bf70e49f5b59f136214027110bbe19e8ced1e6c Mon Sep 17 00:00:00 2001 From: Adrien Schaegis Date: Thu, 24 Nov 2016 19:13:12 +0100 Subject: [PATCH 3/4] [FIX] Correct isset --- src/Message/CreateSubscriptionRequest.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Message/CreateSubscriptionRequest.php b/src/Message/CreateSubscriptionRequest.php index f7cc12bf..a3d6ae87 100644 --- a/src/Message/CreateSubscriptionRequest.php +++ b/src/Message/CreateSubscriptionRequest.php @@ -61,8 +61,7 @@ public function getData() 'plan' => $this->getPlan() ); - - if (isset($this->parameters->has('tax_percent'))) { + if ($this->parameters->has('tax_percent')) { $data['tax_percent'] = (float)$this->getParameter('tax_percent'); } From 25728b5499870598f06861323955dfc9416bc920 Mon Sep 17 00:00:00 2001 From: Adrien Schaegis Date: Wed, 3 May 2017 11:21:58 +0200 Subject: [PATCH 4/4] [UPDATE] phpdoc --- src/Message/CreateSubscriptionRequest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Message/CreateSubscriptionRequest.php b/src/Message/CreateSubscriptionRequest.php index a3d6ae87..1f9f1892 100644 --- a/src/Message/CreateSubscriptionRequest.php +++ b/src/Message/CreateSubscriptionRequest.php @@ -40,11 +40,11 @@ public function setPlan($value) */ public function getTaxPercent() { - return $this->getParameter('plan'); + return $this->getParameter('tax_percent'); } /** - * Set the plan ID + * Set the tax percentage * * @return CreateSubscriptionRequest provides a fluent interface. */