New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build successful despite of unit test failures #36

Closed
GodsBoss opened this Issue Apr 4, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@GodsBoss
Contributor

GodsBoss commented Apr 4, 2016

See https://travis-ci.org/thephpleague/period/jobs/117922991 - although there is one failed test, the build is successful.

nyamsprod added a commit that referenced this issue Apr 5, 2016

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod Apr 5, 2016

Member

@GodsBoss
I don't know why you removed your PR. I've made some tweaks to it and made a new branch with the fixes (https://github.com/thephpleague/period/tree/bugfix/createfromday). Strangely HHVM does not like the changes maybe it's a bug in HHVM :) I'll investigate

Member

nyamsprod commented Apr 5, 2016

@GodsBoss
I don't know why you removed your PR. I've made some tweaks to it and made a new branch with the fixes (https://github.com/thephpleague/period/tree/bugfix/createfromday). Strangely HHVM does not like the changes maybe it's a bug in HHVM :) I'll investigate

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod Apr 5, 2016

Member

@GodsBoss
Well it seems to be a HHVM bug that was fixed in later version.
https://3v4l.org/jG6uD
the HHVM version in travis is 3.6.6 and the bug is fixed in version 3.10.x and later

Member

nyamsprod commented Apr 5, 2016

@GodsBoss
Well it seems to be a HHVM bug that was fixed in later version.
https://3v4l.org/jG6uD
the HHVM version in travis is 3.6.6 and the bug is fixed in version 3.10.x and later

nyamsprod added a commit that referenced this issue Apr 11, 2016

nyamsprod added a commit that referenced this issue Apr 11, 2016

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod Apr 15, 2016

Member

The bug fix has been merge into the master branch

Member

nyamsprod commented Apr 15, 2016

The bug fix has been merge into the master branch

@nyamsprod nyamsprod closed this Apr 15, 2016

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod May 9, 2016

Member

Period 3.2 is out with the fix

Member

nyamsprod commented May 9, 2016

Period 3.2 is out with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment