New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepoint::createFromFormat declaration issue with PHP 7.1 #72

Closed
ilianiv opened this Issue Jan 3, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@ilianiv
Copy link

ilianiv commented Jan 3, 2019

Bug Report

Information Description
Version 4.3.0
PHP version 7.1.25
OS Platform Ubuntu 16.04.5 LTS

Summary

After upgrade league/period (4.0.1 => 4.3.0) I've got this warning:

Declaration of League\Period\Datepoint::createFromFormat($format, $datetime, ?DateTimeZone $timezone = NULL) should be compatible with DateTimeImmutable::createFromFormat($format, $time, $object = NULL)

Standalone code, or other way to reproduce the problem

Here is a dummy DateTimeImmutable extender class simulating Datepoint class in a playground
https://www.tehplayground.com/nvl4opycmrAOJbIt

@ilianiv ilianiv changed the title League\Period\Datepoint::createFromFormat declaration issue with PHP 7.1 Datepoint::createFromFormat declaration issue with PHP 7.1 Jan 3, 2019

@nyamsprod nyamsprod self-assigned this Jan 3, 2019

@nyamsprod nyamsprod added the bug label Jan 3, 2019

@nyamsprod

This comment has been minimized.

Copy link
Member

nyamsprod commented Jan 4, 2019

@ilianiv thanks for reporting this issue it has been added to the #73 PR and will be released when the merge is done.

nyamsprod added a commit that referenced this issue Jan 7, 2019

@nyamsprod

This comment has been minimized.

Copy link
Member

nyamsprod commented Jan 7, 2019

new release version 4.3.1 with the fix included

@nyamsprod nyamsprod closed this Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment