New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Period::contains edge checking is confusing #28

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bendavies

bendavies commented Dec 21, 2015

There is some weirdness with edge checking that I've encountered.

Consider the following:

Period::createFromYear(2015)->contains(Period::createFromQuarter(2015, 4));

What would you think that should return?
I would say true, but the current implementation will return false. This seems very counterintuitive, given the example.

Thoughts?

I realise this PR fails the tests. It's just for a discussion starting point.

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod Dec 21, 2015

Member

Oki I found the bug and I've just fixed it 👍 It will be on the master branch and published tomorrow if I have the time. I'll let you know ASAP!

Member

nyamsprod commented Dec 21, 2015

Oki I found the bug and I've just fixed it 👍 It will be on the master branch and published tomorrow if I have the time. I'll let you know ASAP!

@bendavies

This comment has been minimized.

Show comment
Hide comment
@bendavies

bendavies commented Dec 21, 2015

thanks!

nyamsprod added a commit that referenced this pull request Dec 21, 2015

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod Dec 21, 2015

Member

@bendavies the bug fix landed on master... you can already try it there. If everything is good I'll put it on production tomorrow

Member

nyamsprod commented Dec 21, 2015

@bendavies the bug fix landed on master... you can already try it there. If everything is good I'll put it on production tomorrow

@bendavies

This comment has been minimized.

Show comment
Hide comment
@bendavies

bendavies Dec 21, 2015

awesome! thanks

bendavies commented Dec 21, 2015

awesome! thanks

@bendavies

This comment has been minimized.

Show comment
Hide comment
@bendavies

bendavies Dec 22, 2015

That's great. please tag away!

bendavies commented Dec 22, 2015

That's great. please tag away!

@bendavies bendavies closed this Dec 22, 2015

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod Dec 22, 2015

Member

version 3.0.1 is released

Member

nyamsprod commented Dec 22, 2015

version 3.0.1 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment