New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method signature to return null and added tests #219

Closed

ricardofiorani wants to merge 1 commit into thephpleague:master from ricardofiorani:fix-nullable-type

ricardofiorani commented Oct 22, 2018 •

edited

The statement is never reached due to wrong type return, and instead will raise an internal php error.

This PR intends to fix that.


          fixed method signature to return null and tests

f873478

Member

philipobenito commented Jan 17, 2019

This is actually addressed in another PR and will be released in the next major version.

philipobenito closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment