New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure files/folders of new front-end code #327

Open
maestromac opened this Issue Aug 10, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@maestromac
Collaborator

maestromac commented Aug 10, 2018

@nickytonline commented on Thu Aug 02 2018

TASK

Just some housekeeping...

We're not a full blown SPA. We have components sprinkled into the site, e.g. Chat, Search (soon to be expanded on).

Initially, there was only on-boarding code in the new front-end code base. Since other things are there now, e.g. Search, chat etc., here's what I propose:

  • files/folders for new front-end stuff should either all be moved under ./app/javascript/src. or ./app/javascript. I'm used to a src folder, but given that we're already a couple levels deep in the folder structure, the javascript folder may make sense as the root.
  • on-boarding components should be under an Onboarding folder.
  • rename ./app/javascript/packs/pack.js to ./app/javascript/packs/Onboarding.jsx as it really is the entry point file for on-boarding.
  • Have a components folder for common components
  • Have a views folder which have subfolders that are full-blown features, e.g. Chat. In those folders, there'd be a components folder for all the pieces of that particular feature.

Thoughts @benhalpern, @maestromac? Just trying to get things tidied up before the world sees everything ;)

Screenshots

Current folder structure

image

Potential new folder structure

image


@nickytonline commented on Fri Aug 10 2018

I know this issue will be moved to the new repo, so I'll fork and branch, but just wondering if you're OK with me going ahead with this change @maestromac and @benhalpern. I wanted to get this in before the OSS release, but the beach was calling. 😉🐚🌴

@maestromac

This comment has been minimized.

Collaborator

maestromac commented Aug 10, 2018

Hey @nickytonline , @benhalpern and I are 100% onboard with this proposal. Our original plan was to follow webpacker's suggestion but we may have strayed away from that line. This looks super neat 👍

@nickytonline

This comment has been minimized.

Contributor

nickytonline commented Aug 10, 2018

Cool, thanks @maestromac. I'll PR this up tomorrow night or the next.

@stale

This comment has been minimized.

stale bot commented Nov 10, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

@stale stale bot added the stale label Nov 10, 2018

@maestromac

This comment has been minimized.

Collaborator

maestromac commented Nov 12, 2018

unstale

@stale stale bot removed the stale label Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment