Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the tag edit pages #3953

Closed
omenking opened this issue Sep 5, 2019 · 9 comments

Comments

@omenking
Copy link
Contributor

commented Sep 5, 2019

This form can use some styling love.
For a moderator who wants to fill in a considerable amount of markup, it is a bit cumbersome.

Screen Shot 2019-09-05 at 2 47 10 PM

@timrodz

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Hi @omenking, I'd be interested in helping out with this.

Are there any specific features you'd like to use as a moderator? This would help me craft a better implementation.

@omenking

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

I can't think of any additional features.
Colour pickers would be nice for the coloured boxes.
A popup which displays markdown rules would be useful.
Larger boxes. For bonus points create a tab which can switch from markdown to preview.
And if you really want to go for it do it in preact.

Again you can just adjust the styling, but just some more ideas you can run with.

@timrodz

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Thanks for the suggestions!

As I haven't used Ruby (yet), I'll be looking at completing the basics first (Styling -> Colour pickers -> Markdown syntax popup)

@timrodz

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

Hi @omenking, I've just had a chance to touch this now. How does someone navigate to this page? I might need access to mod priviledges so I can test this in my own setup.

@omenking

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2019

So the page you're looking at is this url:

https://dev.to/t/rails/edit

If the app is following convention then it would be in views/tags/edit.html.erb and the controller responsible should be TasksController.

How someone gets to set as an admin could be a column on the users table or a join table called moderators. A good place to look is the schema.rb to get hints. Probably checking the user.rb and search moderator will help.

@omenking

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2019

Moderators might be set via a role:

  create_table "users_roles", id: false, force: :cascade do |t|
    t.integer "role_id"
    t.integer "user_id"
    t.index ["user_id", "role_id"], name: "index_users_roles_on_user_id_and_role_id"
  end
@timrodz

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

Thanks! I was able to authenticate and can now see the tag page.

@timrodz

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

I have noticed there's a basic colour picker implemented for the boxes - It pops up when you click on the text field:
Screen Shot 2019-09-29 at 4 12 04 PM

@timrodz timrodz referenced this issue Sep 30, 2019
2 of 7 tasks complete
@maestromac

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

Resolved with #4137

@maestromac maestromac closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.