Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose config for developing and running tests #1125

Closed
wants to merge 3 commits into from

Conversation

@dsalahutdinov
Copy link

commented Nov 15, 2018

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Added a couple of features for running project with docker:

  • persistent volumes for database, bundles, node_modules etc
  • support for test environment in docker compose, running specs by docker-compose run app bundle exec rspec
    -extracted special base service app for running tasks
  • install postgres client to support rails db and browsing database
  • minor documentation improvements

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@pr-triage pr-triage bot added the PR: unreviewed label Nov 15, 2018
@CLAassistant

This comment has been minimized.

Copy link

commented Nov 15, 2018

CLA assistant check
All committers have signed the CLA.

@benhalpern

This comment has been minimized.

Copy link
Collaborator

commented Nov 15, 2018

I don't have a strong opinion here. @maestromac feel free to merge this if you like.

docker-compose.yml Outdated Show resolved Hide resolved
@dsalahutdinov

This comment has been minimized.

Copy link
Author

commented Nov 20, 2018

@maestromac could you please review?

Copy link
Collaborator

left a comment

Sorry, this took so long. Seems to work well and faster than what we have. LGTM & Thanks!


ENTRYPOINT ["bundle", "exec"]
ADD https://github.com/krallin/tini/releases/download/v0.18.0/tini /tini

This comment has been minimized.

Copy link
@maestromac

maestromac Jan 17, 2019

Collaborator

Tini's documentation stated that

NOTE: If you are using Docker 1.13 or greater, Tini is included in Docker itself. This includes all versions of Docker CE. To enable Tini, just pass the --init flag to docker run.

Does that apply here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.