Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect width jump fix #1652

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
2 participants
@mariocsee
Copy link
Collaborator

commented Jan 25, 2019

What type of PR is this? (check all applicable)

  • Refactor

Description

Issue #1650 describes a jump in connect when loaded in smaller screens. Based on some testing, it was because of the min-width and max-width under .chat__activechat that created about a 155px range for the chat to expand or contract. It seems when loading it takes the minimum first then adjusts the width to fit the screen—creating that jump.

I removed that range and allow the chat to fill the screen immediately. Though because of how .chat__channels and .chat__channels--expanded is implemented, there is an observed growth on the left border of .chat__activechat due to the JavaScript side loading and removing --expanded from the class to shrink the chat channels on the left and make more space for the chat. I've attached screenshots below on mobile sizes of the app locally running and loading to demonstrate.

Related Tickets & Documents

resolves #1650

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

screen shot 2019-01-25 at 15 35 10 2
screen shot 2019-01-25 at 15 35 14 2
screen shot 2019-01-25 at 15 33 25 2
screen shot 2019-01-25 at 15 34 05 2

Added to documentation?

  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed label Jan 25, 2019

@mariocsee mariocsee requested a review from benhalpern Jan 25, 2019

@benhalpern
Copy link
Collaborator

left a comment

This is fabulous!

@benhalpern benhalpern merged commit 1404f0d into thepracticaldev:master Jan 26, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 87% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@mariocsee mariocsee deleted the mariocsee:connect-style-jump branch Jan 27, 2019

@mariocsee mariocsee self-assigned this Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.