Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long lines doesn't wrap bug for user profiles. #1710 #1715

Merged

Conversation

Projects
None yet
3 participants
@aligoren
Copy link
Contributor

commented Feb 2, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Long lines are getting cut off on the left sidebar for user profiles. @jessleenyc Also caught it.

Related Tickets & Documents

Closed #1710

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before

sidebar1

After

sidebar2

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed label Feb 2, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented Feb 2, 2019

CLA assistant check
All committers have signed the CLA.

@pr-triage pr-triage bot removed the PR: unreviewed label Feb 2, 2019

@benhalpern benhalpern merged commit 4e09a95 into thepracticaldev:master Feb 2, 2019

6 of 7 checks passed

deploy/netlify Deploy preview failed.
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 87% (0.0% change)
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.