Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray forward slashes in RSS feed builder #1943

Merged

Conversation

Projects
None yet
2 participants
@shindakun
Copy link
Contributor

commented Mar 1, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • URLs in the Link and GUID field in RSS have an extra slash. This PR removes stray / from lines 17 and 18.

Related Tickets & Documents

closes #1942

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

slash

Remove stray forward slash in RSS feed builder
closes #1942

- removed stray `/` from lines 17 and 18.

@pr-triage pr-triage bot added the PR: unreviewed label Mar 1, 2019

@benhalpern
Copy link
Collaborator

left a comment

Fabulous

@pr-triage pr-triage bot removed the PR: unreviewed label Mar 2, 2019

@benhalpern benhalpern merged commit 3cc0f27 into thepracticaldev:master Mar 2, 2019

5 checks passed

codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@shindakun shindakun deleted the shindakun:issue/1942-forwardslash branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.