Add initial charts implementation to pro dashboard #2037
Conversation
| class ChartDecorator < Draper::CollectionDecorator | ||
| def total_by_type_per_day(options) | ||
| case options[:type] | ||
| when "Comment" |
There was a problem hiding this comment.
This when statement is not being used, but will probably be used in the next implementation. I wrote it more as an example.
|
Oh nice! What qualifies one as a pro? And let me know if you need beta testers. ;) |
Co-Authored-By: Zhao-Andy <andyzhao.zhao@gmail.com>
pr-triage
bot
added
PR: reviewed-changes-requested
Co-Authored-By: Zhao-Andy <andyzhao.zhao@gmail.com>
pr-triage
bot
added
PR: unreviewed
pr-triage
bot
added
PR: reviewed-approved
| @last_week_reactions_count = Reaction.where(reactable_id: current_user.articles.pluck(:id), reactable_type: "Article").where("created_at > ? AND created_at < ?", 2.weeks.ago, 1.week.ago).size | ||
| @this_month_reactions_count = Reaction.where(reactable_id: current_user.articles.pluck(:id), reactable_type: "Article").where("created_at > ?", 1.month.ago).size | ||
| @last_month_reactions_count = Reaction.where(reactable_id: current_user.articles.pluck(:id), reactable_type: "Article").where("created_at > ? AND created_at < ?", 2.months.ago, 1.months.ago).size | ||
| @current_user_article_ids = current_user.articles.pluck(:id) |
There was a problem hiding this comment.
I suggest using a facade pattern here instead of using lots of instance variables.
Like creating a class Dashboards::Pro (or another name) with the corresponding methods.
Example
There was a problem hiding this comment.
- that would allow to add a separate test for the data easier.
There was a problem hiding this comment.
This makes sense. @Zhao-Andy refactoring as such sooner rather than later is probably good.
|
@shindakun right now this is pretty secluded because we haven't built this to scale to very many users. The question of what qualifies as "pro" is to be determined, and a lot of these components will be general availability depending on what scales easily and what doesn't. I'll make sure you get on the list for early access. |
pr-triage
bot
added
PR: merged
What type of PR is this? (check all applicable)
Description
This PR adds some basic time-series charts to the pro dashboard. It also lays some groundwork for code to be reused for other charts/data-visualizations.
Code/implementation-detail-wise there are a lot of individual queries, which would grow as we want more and different kinds of data. What we might want to do is move them into
javascript_pack_tagsthat call an API endpoint for the specific data, and then have it render afterward.There's more to add for sure, but I think this will be a good start.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)