Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send new follower notification when followable is a tag #2041 #2050

Merged
merged 2 commits into from Mar 13, 2019

Conversation

lightalloy
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Bug Fix

Description

  • added checks to ensure followable is a User or an Organization before sending a notification
  • added specs

Related Tickets & Documents

#2041

@lightalloy
Copy link
Contributor Author

The fix makes Cognitive Complexity a bit worse (as CodeClimate complains), but that's a topic for another pr in my opinion.

@benhalpern benhalpern merged commit 96de5a4 into forem:master Mar 13, 2019
@pr-triage pr-triage bot added the PR: merged bot applied label for PR's that are merged label Mar 13, 2019
@lightalloy lightalloy deleted the fix/no-tag-follow-notifications branch March 9, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants