Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper css vars to user style config #2105

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
1 participant
@benhalpern
Copy link
Collaborator

commented Mar 18, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This renders the proper night theme using CSS variables. This currently takes hardcoded theme info right in application.html.erb but could be modified to take variables in the future.

Also added another font option: comic sans.

@benhalpern benhalpern merged commit 2b2ecaa into master Mar 18, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 3 fixed issues
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@pr-triage pr-triage bot added the PR: merged label Mar 18, 2019

@maestromac maestromac deleted the ben/modify-config branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.