Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace puts with proper logging #2139

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@rhymes
Copy link
Collaborator

commented Mar 20, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

While examining another PR I noticed there was a puts in the wild in an error handler, I decided to use proper logging instead, ended up replacing all puts.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed
@maestromac
Copy link
Collaborator

left a comment

Wow, can't believe we have this muchputs. Thanks @rhymes !

@maestromac maestromac merged commit 116d6b3 into thepracticaldev:master Mar 21, 2019

6 of 7 checks passed

codeclimate/diff-coverage 7% (50% threshold)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@pr-triage pr-triage bot added the PR: merged label Mar 21, 2019

@rhymes rhymes deleted the rhymes:rhymes/puts-be-gone branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.