Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a list of followed organizations to dashboard #2157

Conversation

@dabrorius
Copy link
Contributor

commented Mar 21, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Add a list of followed organizations to user's dashboard.

Related Tickets & Documents

#1958

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screen Shot 2019-03-20 at 15 53 47

Screen Shot 2019-03-21 at 14 36 14

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 21, 2019

CLA assistant check
All committers have signed the CLA.

@dabrorius

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Note: While working on this PR I notice two potential issues.

  1. There seems to be some flaky specs around features/comments
  2. There seems to be a duplicated route dashboard/following_users and dashboard/followings, this might be better handled with a redirection to a single canonical route.
@benhalpern
Copy link
Collaborator

left a comment

Looks good to me, thanks a lot!

@benhalpern

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

@dabrorius yes, we need to improve some of these flaky feature specs.
I think the duplicate route can be removed altogether. It was placed to maintain backwards compatibility at first but I think enough time has passed that we can forget about it altogether and stick to the route linked to within the app. I doubt there are any useful links on the web that go to that specific page.

@benhalpern benhalpern merged commit 937bc63 into thepracticaldev:master Mar 21, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@pr-triage pr-triage bot added the PR: merged label Mar 21, 2019

@dabrorius

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@benhalpern thanks for the quick review!
I'll make a new PR to remove the old route early next week.
I'll give fixing flaky specs another shot after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.