Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `dashboard/following_users` route #2191

Conversation

Projects
None yet
2 participants
@dabrorius
Copy link
Contributor

commented Mar 25, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

The dashboard/following_users route has been deprecated a while ago and replaced with dashboard/following route.
This commit removes the old route and updates the code to reflect it.

Related Tickets & Documents

This was discussed briefly with @benhalpern here: #2157 (comment)

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

No UI changes

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

wintermoon

Remove `dashboard/following_users` route
The `dashboard/following_users` route has been deprecated a while ago
and replaced with `dashboard/following` route.
This commit removes the old route and updates the code to reflect it.

@pr-triage pr-triage bot added the PR: unreviewed label Mar 25, 2019

@maestromac
Copy link
Collaborator

left a comment

LGTM!

@maestromac maestromac merged commit 88fc2a6 into thepracticaldev:master Mar 25, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.