Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled a couple of rubocop cops which have no violations #2214

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
4 participants
@lightalloy
Copy link
Collaborator

commented Mar 26, 2019

What type of PR is this? (check all applicable)

  • Refactor

Description

Enabled a couple of rubocop cops which have no violations

Related Tickets & Documents

#2021

@pr-triage pr-triage bot added the PR: unreviewed label Mar 26, 2019

Show resolved Hide resolved .rubocop.yml Outdated
@maestromac
Copy link
Collaborator

left a comment

Test passed but the checks wouldn't update 🤷

@maestromac maestromac merged commit 6e23483 into thepracticaldev:master Mar 27, 2019

6 of 7 checks passed

Travis CI - Pull Request Build Started
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@lightalloy lightalloy deleted the lightalloy:enable-rubocop-cops branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.