Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Cache When Merging Users #2229

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
3 participants
@jessleenyc
Copy link
Collaborator

commented Mar 28, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • Update counter cache
  • Keep older created_at date
  • Bust fastly cache

@pr-triage pr-triage bot added the PR: unreviewed label Mar 28, 2019

merge_articles if @delete_user.articles.any?
end

def merge_reactions

This comment has been minimized.

Copy link
@benhalpern

benhalpern Mar 28, 2019

Collaborator

Nice job breaking this into methods

@maestromac maestromac merged commit 9f74fd3 into thepracticaldev:master Mar 28, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.