Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique twitter and github usernames #2061 #2255

Merged

Conversation

Projects
None yet
2 participants
@lightalloy
Copy link
Collaborator

commented Apr 1, 2019

What type of PR is this? (check all applicable)

  • Refactor

Description

I made this pr to prepare to change unique validations for the User github/twitter_usernames to be conditional. That will help with #2061

  • set github and twitter usernames to nil in case they are an empty string: in the User model and in the Admin::UsersController (just in case)
  • added unique indexes to these fields in the database

Before merging:

  • make sure there are no records with duplicate twitter_usernames or github_usernames in the users table
  • make sure there are no records with empty strings values in these fields (update them to nil in this case).

Related Tickets & Documents

#2061

@pr-triage pr-triage bot added the PR: unreviewed label Apr 1, 2019

@lightalloy lightalloy referenced this pull request Apr 2, 2019

Merged

db transactions for safer merging of users #2281

2 of 7 tasks complete

lightalloy and others added some commits Apr 2, 2019

@benhalpern
Copy link
Collaborator

left a comment

Looks good!

@pr-triage pr-triage bot removed the PR: unreviewed label Apr 2, 2019

@benhalpern benhalpern merged commit 1a0d466 into thepracticaldev:master Apr 2, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 90% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@lightalloy lightalloy deleted the lightalloy:unique-twitter-github-usernames branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.