Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix human language detection #2338

Merged
merged 2 commits into from Apr 8, 2019
Merged

Fix human language detection #2338

merged 2 commits into from Apr 8, 2019

Conversation

benhalpern
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Replace our broken language detection service with a Ruby version. This is probably less reliable, but is definitely reliable enough and better than nothing.

This also adds the home feed functionality for favoring the preferred language of the current user.

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 8, 2019
@benhalpern benhalpern merged commit bd95c6a into master Apr 8, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Apr 8, 2019
@maestromac maestromac deleted the ben/language-detection branch April 9, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant