Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini refactor to make variable names clearer in the Categories component #4257

merged 1 commit into from Oct 6, 2019


Copy link

nickytonline commented Oct 6, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update


Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

We have no names man!

@pr-triage pr-triage bot added the PR: unreviewed label Oct 6, 2019
const { categoriesForSelect, category } = this.props
return => {
const { categoriesForSelect, category } = this.props;
return[text, value]) => {

This comment has been minimized.

Copy link

nickytonline Oct 6, 2019

Author Member

This is the refactoring here. The rest below line 20 is just prettier kicking in.

@nickytonline nickytonline changed the title Mini refactor to make var names clearer. Mini refactor to make variable names clearer in the Categories component Oct 6, 2019
rhymes approved these changes Oct 6, 2019
Copy link

rhymes left a comment


Maybe drop a note into #2470

@benhalpern benhalpern merged commit 30cc799 into thepracticaldev:master Oct 6, 2019
8 checks passed
8 checks passed
Gitpod Open an online workspace in Gitpod
Travis CI - Pull Request Build Passed
WIP Ready for review
codeclimate All good!
codeclimate/diff-coverage 100% (50% threshold)
codeclimate/total-coverage 91%
deploy/netlify Deploy preview ready!
license/cla Contributor License Agreement is signed.
@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Oct 6, 2019
@nickytonline nickytonline deleted the nickytonline:categories-component-mini-refactor branch Oct 6, 2019
@rhymes rhymes mentioned this pull request Oct 7, 2019
2 of 7 tasks complete
RakChamp25 added a commit to RakChamp25/ that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.