Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now eslint ignores the app/assets/javascripts/lib folder. #4323

merged 1 commit into from Oct 8, 2019


Copy link

nickytonline commented Oct 8, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update


The app/assets/javascripts/lib should be completely ignored by eslint as it is a folder that contains 3rd party libs, e.g. pulltorefresh.js and xss.js

This PR adds that entire folder to eslint's ignore list.

Related Tickets & Documents


Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Dick Van Dyke Dancing in Mary Poppins

@pr-triage pr-triage bot added the PR: unreviewed label Oct 8, 2019
Copy link

maestromac left a comment

Thanks for this @nickytonline !

@maestromac maestromac merged commit f7f3380 into thepracticaldev:master Oct 8, 2019
8 checks passed
8 checks passed
Gitpod Open an online workspace in Gitpod
Travis CI - Pull Request Build Passed
WIP Ready for review
codeclimate All good!
codeclimate/diff-coverage 100% (50% threshold)
codeclimate/total-coverage 91% (0.1% change)
deploy/netlify Deploy preview ready!
license/cla Contributor License Agreement is signed.
@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Oct 8, 2019
RakChamp25 added a commit to RakChamp25/ that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.