Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade to webpacker/webpack 4 and Babel 7 #6664
What type of PR is this? (check all applicable)
Frontend infrastructure has been updated. We are now running on Babel 7 and webpacker/webpack 4.
This removes a blocker for upgrading to Rails 6 (webpacker 4) and will also allow us to upgrade to the latest Storybook.
Note: I will update Storybook in another PR, so it will temporarily be broken.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
maestromac left a comment
I'm so excited for this! Tested locally, LGTM
also, would you like to temporarily comment-out/remove
@rhymes, good question. We could move other assets from sprockets to webpack. For stylesheets, they'd be inlined and hot reloaded during development and for production, it would generate actual CSS files via the MiniCSSExtract plugin. If that is not set up in our webpack config it could be added fairly easily.
There also have been projects that have completely moved away from Sprockets, but in our case, I don't think that would be possible at the moment and I'm not even sure we'd want to do that.