[Article Actions] Using position sticky #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @juanmanuelramallo we actually had to revert this change. There were some weird small issues with hovering and 1px jumps. (Plus the removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Changed position of article actions bar (or reactions).
Keep bar in the bottom of the article section using
position: sticky.This was recently discussed here.
Main motivation on this is that it doesn't make sense (at least to me 馃檲) to have reaction buttons for the article when you are below its container, cause you are actually seeing suggestions to read other articles.
Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Gif showing it in action
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?
https://imgur.com/gallery/aX1c9FW