Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-check plugin versions from directory, buildversion.txt and JVM-compiled code. #381

Open
vinjana opened this issue May 29, 2024 · 1 comment

Comments

@vinjana
Copy link
Contributor

vinjana commented May 29, 2024

In function LibrariesFactory.loadPluginsFromDirectories do not only read the directory-based version but also the versions from the buildversion.txt and retrieve the built version from the JVM-compiled BasePlugin-subclass, and cross-check that they are compatible (not necessarily identical?).

@vinjana
Copy link
Contributor Author

vinjana commented May 29, 2024

Problem for JVM-compiled code. de.dkfz.roddy.plugins.ClassLoaderHelper#searchForClass loads the JAR files, but with a hand-crafted approach. The BasePlugin classes (usually 1; possibly multiple!) are not known from the manifest, so they would have to be searched first. Only then the we could call String BasePlugin.getVersionInfo()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant