fix(render): when rendering a reflected HTML attribute, first check i…

…f the property is already set, since it may trigger setters inadvertently
thesephist · May 11, 2019 · 50f158a · 50f158a
1 parent 5509dbc
commit 50f158a
Show file tree

Hide file tree

Showing 8 changed files with 595 additions and 591 deletions.
diff --git a/docs/torus.js.html b/docs/torus.js.html
diff --git a/samples/conway/index.min.js b/samples/conway/index.min.js
diff --git a/samples/graph-calc/index.min.js b/samples/graph-calc/index.min.js
diff --git a/samples/gravity/index.min.js b/samples/gravity/index.min.js
diff --git a/samples/hn-reader/index.min.js b/samples/hn-reader/index.min.js
diff --git a/samples/markus/index.min.js b/samples/markus/index.min.js
diff --git a/samples/mondrian/index.min.js b/samples/mondrian/index.min.js
diff --git a/src/torus.js b/src/torus.js
@@ -335,7 +335,9 @@ const render = (node, previous, next) => {
                 } else if (attrName in node) {
                     // @debug
                     render_debug(`Set <${next.tag}> property ${attrName} = ${next.attrs[attrName]}`);
-                    node[attrName] = next.attrs[attrName];
+                    if (previous.attrs[attrName] !== next.attrs[attrName]) {
+                        node[attrName] = next.attrs[attrName];
+                    }
                 } else {
                     if (next.attrs[attrName] !== previous.attrs[attrName]) {
                         // @debug