From af591705ebcdb20ef7ea42b7d72a031645ca8de5 Mon Sep 17 00:00:00 2001 From: brianheineman Date: Tue, 21 May 2024 11:31:59 -0600 Subject: [PATCH] build: enable windows builds --- .github/workflows/ci.yml | 6 +++--- postgresql_commands/src/traits.rs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6649627..95efeb4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: build: name: ${{ matrix.platform }} - needs: [checks] + needs: [ checks ] runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -36,8 +36,8 @@ jobs: os: macos-14 - platform: macos-x64 os: macos-13 - #- platform: windows-x64 - # os: windows-2022 + - platform: windows-x64 + os: windows-2022 steps: - name: Checkout source code diff --git a/postgresql_commands/src/traits.rs b/postgresql_commands/src/traits.rs index a69b1dc..1d0db21 100644 --- a/postgresql_commands/src/traits.rs +++ b/postgresql_commands/src/traits.rs @@ -198,7 +198,7 @@ impl AsyncCommandExecutor for tokio::process::Command { // on windows, pg_ctl start will appear to hang if you try to read out all of stdout // and stderr. so, on windows do a horrible hack and forcibly end reading of stdout // and stderr 50ms after the process exits. on not-windows, this early exit mechanism - // is set up but never sent to, resulting in the same behavior as `read_to_end`. + // is set up but never sent to, resulting in the same behavior as `read_to_end`. let (exit_anyway_broadcast_sender, exit_anyway_broadcast_receiver_stdout) = tokio::sync::broadcast::channel(1);