Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASoC: SOF: i.MX: simplify Kconfig #3180

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

plbossart
Copy link
Member

Follow the Intel example and simplify the Kconfig
a) start from the end-product and use snd-sof-of as a helper
b) use 'depends on' to filter out configurations.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@plbossart
Copy link
Member Author

@dbaluta this is inspired by the changes that we made on the Intel side based on @arndb's feedback. Much better to consider snd-sof-of as a helper and start the user selection at the product level.

@@ -40,12 +40,14 @@ config SND_SOC_SOF_ACPI_DEV
config SND_SOC_SOF_OF
tristate "SOF OF enumeration support"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart i think this code is more clear. On the other hand saying that snd-sof-of is a 'helper' doesn't make much sense in my understanding.

snd-sof-of is the starting point for the OF platform driver:

sound/soc/sof/sof-of-dev.c

/* DT driver definition */
static struct platform_driver snd_sof_of_driver = {
»       .probe = sof_of_probe,
»       .remove = sof_of_remove, 
»       .driver = {
»       »       .name = "sof-audio-of",
»       »       .pm = &sof_of_pm,
»       »       .of_match_table = sof_of_ids,
»       },
};
module_platform_driver(snd_sof_of_driver);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a pure library indeed, but the point is that sof-of-dev is at the end of the 'select' clauses, it does not select anything on its own. Maybe 'common module' is a better wording.

dbaluta
dbaluta previously approved these changes Sep 28, 2021
Follow the Intel example and simplify the Kconfig
a) start from the end-product for 'select' chains
b) use 'depends on' to filter out configurations.
c) use snd-sof-of as a common module without any 'select'

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@dbaluta dbaluta merged commit 1e6c322 into thesofproject:topic/sof-dev Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants