ipc4: dai: update wallclock for position update #5568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanderWang
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
The original code was copied from ipc3 path but the wallclock usage is different. In ipc4 path fw needs update it for each position update. Signed-off-by: Rander Wang <rander.wang@intel.com>
plbossart
reviewed
Mar 18, 2022
| @@ -308,6 +308,8 @@ void dai_dma_position_update(struct comp_dev *dev) | |||
| status.ipc_posn_data = llp_data; | |||
| dma_status(dd->chan, &status, dev->direction); | |||
|
|
|||
| platform_dai_wallclock(dev, &dd->wallclock); | |||
|
|
|||
There was a problem hiding this comment.
@RanderWang @mmaka1 can you confirm when this dma_position_update happens? it's my understanding that it must happen on a 1ms basis, not just when there a DMA event.
There was a problem hiding this comment.
@plbossart yes, it is called by each dai_copy which is scheduled 1ms basis
lgirdwood
reviewed
Mar 18, 2022
mwasko
approved these changes
Mar 21, 2022
plbossart
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was copied from ipc3 path but the wallclock usage
is different. In ipc4 path fw needs update it for each position update.
Signed-off-by: Rander Wang rander.wang@intel.com