Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential message delivery issue in 3.6.2 #37

Closed
kwquick opened this issue Mar 1, 2017 · 3 comments
Closed

Potential message delivery issue in 3.6.2 #37

kwquick opened this issue Mar 1, 2017 · 3 comments

Comments

@kwquick
Copy link
Contributor

kwquick commented Mar 1, 2017

I am currently investigating what may be a message delivery issue regression in the 3.6.2 release. I have not confirmed this yet, nor isolated it to just 3.6.2, but there is preliminary indication of occasional non-delivery issues using this release.

I will post more here as information becomes available.

@kwquick
Copy link
Contributor Author

kwquick commented Mar 2, 2017

Provisionally fixed in 3.6.3 by reverting the commit that appeared to cause this regression. A more thorough analysis and fix is still underway and will be in a future release.

@kwquick kwquick closed this as completed Mar 2, 2017
@kwquick
Copy link
Contributor Author

kwquick commented Mar 4, 2017

This update did not fully resolve the issue, as noted by testing done by Daniel Mitterdorfer and reported on the mailing list:

I've updated to 3.6.3 and torture CI again.

I also ran the whole test suite now on the following system:

On the latest master (revision XXX) I got three test failures (I ran the whole test twice and got the same error both times):

__________________________________ TestFuncCreateActor_LoadTorture.test10_verify_multiple_sub_actor_creates[multiprocTCPBase] __________________________________

      assert "Saw: %d" % count in answers

E assert ('Saw: %d' % 99) in ['Saw: 0', 'Saw: 1', 'Saw: 2', 'Saw: 3', 'Saw: 4', 'Saw: 5', ...]

test_createActor.py:106: AssertionError
___________________________ TestFuncCreateActor_LoadTorture.test10_verify_multiple_sub_actor_creates[multiprocTCPBase-AdminRouting] ____________________________

      assert "Saw: %d" % count in answers

E assert ('Saw: %d' % 99) in ['Saw: 0', 'Saw: 1', 'Saw: 2', 'Saw: 3', 'Saw: 4', 'Saw: 5', ...]

test_createActor.py:106: AssertionError
________________________ TestFuncCreateActor_LoadTorture.test10_verify_multiple_sub_actor_creates[multiprocTCPBase-AdminRoutingTXOnly] _________________________

      assert "Saw: %d" % count in answers

E assert ('Saw: %d' % 99) in ['Saw: 0', 'Saw: 1', 'Saw: 2', 'Saw: 3', 'Saw: 4', 'Saw: 5', ...]

test_createActor.py:106: AssertionError

===================================== 3 failed, 1823 passed, 213 skipped, 4 xfailed, 33 pytest-warnings in 1462.80 seconds =====================================

I also checked out the tag "thespian-3.6.0" and ran the whole test suite again. It finished without errors:

========================================== 1770 passed, 221 skipped, 4 xfailed, 32 pytest-warnings in 1457.47 seconds ==========================================

The master revision I tested was f3409f8.

@kwquick kwquick reopened this Mar 4, 2017
@kwquick
Copy link
Contributor Author

kwquick commented Mar 20, 2017

After some additional investigation, I believe that the test_createActor.py failures described above are separate from the message delivery issue that the 3.6.3 release addressed. I have created #39 to track the test_createActor.py failures and an re-closing this because 3.6.3 seems to adequately address this issue.

@kwquick kwquick closed this as completed Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant