✨ Improve boxcutter experimental parity #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
…re component Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
changed the title
thetechnick
reviewed
Aug 1, 2025
| } | ||
|
|
||
| if len(reg.CSV.Spec.WebhookDefinitions) > 0 && r.CertificateProvider == nil { | ||
| return nil, fmt.Errorf("unsupported bundle: webhookDefinitions are not supported") |
Owner
There was a problem hiding this comment.
This looks more like an internal panic() that can only happen when you forget to setup the CertificateProvider with dependency injection. At least I find this error message to be confusing.
Collaborator
Author
There was a problem hiding this comment.
No, this message is raised to users if they try to install an operator that OLM doesn't yet support.
We have similar messages for bundles the don't support AllNamespaces mode or bundles that define OLM dependencies.
The standard manifest does not enable a webhook feature gate, so in that case, we explicitly are not setting up a CertificateProvider.
thetechnick
approved these changes
Aug 1, 2025
| } | ||
|
|
||
| if len(reg.CSV.Spec.WebhookDefinitions) > 0 && r.CertificateProvider == nil { | ||
| return nil, fmt.Errorf("unsupported bundle: webhookDefinitions are not supported") |
|
Whelp... this got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3 separate commits that bring the boxcutter branch closer to being ready to merge into operator-controller's main branch:
Reviewer Checklist