Keepalive timer handling fixed #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from version 6.0.0, node returns an error ("callback" argument must be a function) when using native keepalives because of setTimeout calling with null timer handler.
|
@theturtle32 does this PR look good for you? It seems to really fix an issue with latest version of Node (see #266). |
theturtle32
approved these changes
Dec 28, 2016
|
I tested it for months with no issues. As far as I know is a good fix. I tried to modify as little as possible the code but, of course, I'm not sure this will fix all critical races related to the same problem. |
|
Fix released as v1.0.24 |
|
@theturtle32 Glad to know that my fix has been accepted! I tested it for months on my server with no issues. I don't know if I fixed the problem in the right way, but I think it's not too bad since I found similar keepalive special handling in the source code, as far as I remember.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from version 6.0.0, node returns an error ("callback" argument must be a function) when using native keepalives because of setTimeout calling with null timer handler.