Cory Fields
theuni

Organizations

@xbmc @bitcoin
Jul 11, 2016
theuni commented on pull request bitcoin/bitcoin#8305
@theuni

Is it necessary to recover from this more than once per remote-node? As-is, it looks like someone could just respond with alternating connecting/no…

Jul 11, 2016
theuni commented on issue bitcoin/bitcoin#8297
@theuni

I see these in my log too. While they're scary, after tracing through for a while, I don't think they're dangerous. (I do think we should fix up to…

Jul 8, 2016
theuni commented on pull request bitcoin/bitcoin#8210
@theuni

@MarcoFalke The pkg-config issue was fixed with 0c928cb. I just tested to see if the xcb issue was reintroduced, and it wasn't. So it looks like we…

Jul 8, 2016
theuni opened pull request bitcoin/bitcoin#8315
@theuni
gitian: Don't require sudo for Linux.
1 commit with 34 additions and 6 deletions
Jul 8, 2016
Jul 7, 2016
theuni commented on pull request bitcoin/bitcoin#8313
@theuni

@yurizhykin I mean everywhere this PR adds a std::list<CTransaction>* removed param, use std::list<std::shared_ptr<CTransaction> >* removed instead.

Jul 7, 2016
theuni commented on pull request devrandom/gitian-builder#123
@theuni

ACK 46c6539

Jul 7, 2016
theuni commented on pull request bitcoin/bitcoin#8304
@theuni

ACK. This should be good to go now.

Jul 7, 2016
theuni opened pull request bitcoin/bitcoin#8314
@theuni
Fix pkg-config issues for 0.13
2 commits with 34 additions and 13 deletions
Jul 7, 2016
Jul 7, 2016
theuni commented on pull request bitcoin/bitcoin#8313
@theuni

Moving from a de-referenced shared_ptr is kinda wonky. How about passing a pointer to a list of shared_ptr instead, which you would grab using GetS…

Jul 6, 2016
theuni commented on issue bitcoin/bitcoin#8260
@theuni

@laanwj Sounds reasonable. It's also possible that there's an issue with building as c++14 (remember that gcc6 defaults to that).

Jul 6, 2016
theuni opened pull request bitcoin/bitcoin#8310
@theuni
build: require boost for bench
1 commit with 1 addition and 1 deletion
Jul 6, 2016
Jul 6, 2016
theuni commented on pull request bitcoin/bitcoin#8304
@theuni

I believe I've tracked this down to a local server config issue. IPs weren't always presented correctly (hooray, Cloudflare!), so the filtering did…

Jul 6, 2016
theuni commented on pull request bitcoin/bitcoin#8304
@theuni

I'm investigating this now. The ranges should be enabled, but I'm seeing failures that I can't pinpoint.

Jul 6, 2016
theuni commented on pull request bitcoin/bitcoin#8293
@theuni

@luke-jr My only concern is that "system_univalue" should not be equated to "don't use any univalue". renaming to need_univalue would suffice.

Jul 6, 2016
theuni commented on pull request bitcoin/bitcoin#8238
@theuni

@fanquake Please have a look at theuni@a8d5faa . That takes the upstream commits, as well as disabling curve, which was necessary for me locally.

theuni created branch zmq-win at theuni/bitcoin
Jul 6, 2016
Jun 30, 2016
theuni commented on pull request bitcoin/bitcoin#8293
@theuni

Concept ACK. A few nits: Please store the test as build_no_programs or build_libs_only or so, so that we only need the ugly xnononono stuff in one…

Jun 30, 2016
theuni commented on pull request bitcoin/bitcoin#8284
@theuni

I'm really not sure that we need to do these. As discussed in the last PR, I think it's useful to backport simple out-of-tree builds to 0.12, but I…

Jun 30, 2016
theuni commented on pull request bitcoin/bitcoin#8284
@theuni

Tests are failing because RPC_TESTS_DIR was added later in fabbf6b. So 3718096 will need to mess with rpcTestDir instead.

Jun 30, 2016
theuni commented on pull request bitcoin/bitcoin#8284
@theuni

You're missing the removal of leveldb here. This is unnecessary now that the files are enumerated in Makefile.leveldb.include

Jun 29, 2016
theuni commented on issue bitcoin/bitcoin#8260
@theuni

@error10: Could you please try this patch? My best guess is that something about your setup is different than most. There's some undefined behavior…

Jun 29, 2016
theuni commented on issue bitcoin/bitcoin#8260
@theuni

Can you run the same thing under gdb? I think it'd be: gdb --args ./test_bitcoin --run_test=reverselock_tests/reverselock_errors then hit r to run,…

Jun 28, 2016
theuni closed pull request theuni/bitcoin#55
@theuni
Made the ForEachNode* functions in src/net.cpp more pragmatic and self documenting
Jun 28, 2016
theuni commented on pull request theuni/bitcoin#55
@theuni

Thanks, cherry-picked in.

Jun 28, 2016
theuni commented on pull request bitcoin/bitcoin#8085
@theuni

Addressed most (all?) of the comments here, and added some commits. For future comparison, the current tip is theuni@f96d164. I'll now work on reba…

Jun 28, 2016
@theuni
Jun 28, 2016
theuni commented on pull request bitcoin/bitcoin#8085
@theuni

Yea, I don't believe this deviates from the current behavior much, other than slightly obfuscating the exact current known height, since the value …