Resolve pylint error: remove outdated exception subscript #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python3 does not support exception subscripting:
e.g. except ... as e:
e[1] # does not work in Python3
This line of code was presumably not covered by testing,
allowing it to persist.
Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
3 tasks
|
Lukas, would you kindly review? It looks good to me. |
trishankatdatadog
approved these changes
Mar 26, 2019
|
I'll merge this since it's valuable to get the build passing again and it's fairly straightforward, but I could still use Lukas's opinion at some point, since we've discussed this. |
lukpueh
reviewed
Mar 27, 2019
There was a problem hiding this comment.
This is the solution we discussed yesterday, and it makes sense, although the name of the Exception class is debatable (as we also discussed yesterday), the except clause should be covered by tests (as we also ...) and tuf's coveralls.io setup needs some fixing (as ...). :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3 does not support exception subscripting:
e.g.
This five-year-old line of code was presumably not covered by testing, allowing it to persist.
I resolved with a minor change: using an error more appropriate to this particular problem, one that already includes a signable field.
In looking at this, I'm not pleased by how differently
developer_tool.pyandrepository_tool.pycode theirstatus()functions.... That merits some attention, but it won't be here.