Nathaniel Watts
thewatts

Aug 17, 2016
@thewatts

Yeah no prob on those tests - but as a heads up - it'll be a little while before I can submit them.

Aug 17, 2016
@thewatts

I was thinking the top example - but for me, this specifically broke when referencing a relationship from inside a namespaced serializer. Ex: belon…

Aug 17, 2016
@thewatts

Yeah it's a tough balance - solid documentation can be a bonus - but it's the first thing to become stale unless tightly monitored. Typically I try…

Aug 17, 2016
@thewatts

We want th ordered by longest namespace first, right? Otherwise if a non-namespaced item exists, ex: CommentSerializer, it would be found before t…

Aug 17, 2016
@thewatts

We could def use .each if we split the string on :: - but we'd have to build the namespaces a little differently. I'm game for either.

Aug 17, 2016
@thewatts

@NullVoxPopuli for the lookup chain and versioning... would we try to specifically look for versioned namespaces? ex: if V2 exists, assume V1 does …

Aug 17, 2016
@thewatts

@NullVoxPopuli Good call! Thanks for the feedback! Adjustments added in most recent commit. Let me know your thoughts!

Aug 17, 2016
@thewatts
  • @thewatts 7cff115
    Tidy dynamic namespace lookup for serializers
Aug 16, 2016
@thewatts

@NullVoxPopuli if this PR is helpful, I absolutely don't mind adding tests (and of course - fixing the one I just broke 😅 )

Aug 16, 2016
@thewatts

@NullVoxPopuli thanks for the reply! And sorry for the late reply on my end - that's quite the chain of issues/PRs to follow. (I'll admit - I skimm…

Aug 16, 2016
@thewatts
  • @thewatts 9412a19
    Extend Serializer lookup for multiple namespaces
Aug 16, 2016
@thewatts
  • @thewatts cd3d501
    Fix Serializer Lookup Chain for Namespaces
Aug 16, 2016
@thewatts
(WIP) Fix Serializer Lookup Chain for Namespaces
1 commit with 2 additions and 0 deletions
Aug 16, 2016
@thewatts
  • @NullVoxPopuli ecc3b35
    Merge pull request #1309 from rails-api/revert-1289-serialization_con…
  • @NullVoxPopuli 17be650
    Revert "rename context to serialization_context and add url helpers"
  • 635 more commits »
Aug 8, 2016
@thewatts

@mcmire the issue on our end (both @philtr and myself) was due to a third party gem, challah. Challah has been fixed - so this is no longer an issu…

Aug 8, 2016
thewatts commented on issue jdtornow/challah#28
@thewatts

@jdtornow thanks!!!

Aug 8, 2016
thewatts commented on issue jdtornow/challah#28
@thewatts

@jdtornow that's the ticket! I had pinpointed the issue in Challah::Audit, but had to jump on a call before I found the culprit. Ya beat me to the …

Aug 8, 2016
thewatts commented on issue jdtornow/challah#28
@thewatts

@jdtornow and to be more specific - we're not adding anything like challah/test to the rails_helper. Just adding challah to the Gemfile will cause …

Aug 8, 2016
thewatts commented on issue jdtornow/challah#28
@thewatts

Context: my comment and subsequent comments and pip's comment Background: For some reason - shoulda/matchers validation of uniqueness is failing (j…

Aug 8, 2016
@thewatts
Challah breaks shoulda/matchers uniqueness?
Aug 8, 2016
thewatts commented on issue jdtornow/challah#29
@thewatts

closing in favor of comment on #28

Aug 8, 2016
@thewatts
Challah breaks shoulda/matchers uniqueness?
Aug 8, 2016
@thewatts
Aug 8, 2016
@thewatts
thewatts created branch master at thewatts/uniqueness
Aug 8, 2016
thewatts created repository thewatts/uniqueness
Aug 8, 2016
Aug 7, 2016
thewatts commented on commit jdtornow/abaci@2239b7b798
@thewatts

🎉 🎉 🎉 🎉 🎉

Aug 7, 2016
thewatts commented on issue neovim/neovim#5176
@thewatts

I may have to wait until 0.1.5 ships to see if that's the fix.

Aug 7, 2016
thewatts commented on issue neovim/neovim#5176
@thewatts

@tweekmonster really appreciate the help! That wasn't the ticket, unfortunately. The file still comes up without any color. I tried to automate the…