Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unfinished events to podium list #52

Merged
merged 2 commits into from Feb 10, 2020

Conversation

@saranshgrover
Copy link
Contributor

saranshgrover commented Feb 10, 2020

Fixes #46

@saranshgrover saranshgrover requested a review from jonatanklosko Feb 10, 2020
@jonatanklosko

This comment has been minimized.

Copy link
Member

jonatanklosko commented Feb 10, 2020

Could you please include a screenshot for the reference?

@saranshgrover

This comment has been minimized.

Copy link
Contributor Author

saranshgrover commented Feb 10, 2020

image

Copy link
Member

jonatanklosko left a comment

Thanks for contributing with the clean implementation, just few comments =)

client/src/components/Podiums/Podiums.js Outdated Show resolved Hide resolved
client/src/components/Podiums/Podiums.js Outdated Show resolved Hide resolved
client/src/components/Podiums/Podiums.js Outdated Show resolved Hide resolved
Copy link
Member

jonatanklosko left a comment

LGTM, thanks! 🎉

@jonatanklosko jonatanklosko merged commit 78303d6 into thewca:master Feb 10, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@saranshgrover saranshgrover deleted the saranshgrover:46-podium-show-all-events branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.