Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the WCA Staff labels visible from the profile #4581

Closed
Ivan-Brigidano opened this issue Sep 7, 2019 · 15 comments
Closed

Make the WCA Staff labels visible from the profile #4581

Ivan-Brigidano opened this issue Sep 7, 2019 · 15 comments

Comments

@Ivan-Brigidano
Copy link
Member

Ivan-Brigidano commented Sep 7, 2019

Right now to identify if someone is a WCA Staff you have to search him/her on WCA Delegates list or the WCA Teams, Committees, and Councils list.

I think it would be helpful if the labels were visible from the profile. So it would be way easier to identify if someone is a Delegate. This is what I mean when saying "labels":

Captura de pantalla 2019-09-07 a las 15 41 18

@moralsh
Copy link
Contributor

moralsh commented Oct 4, 2019

Any Ideas where to place this info? I've got two ideas, right after the name or below, will probably also lose the "Member of" part. I'll try to post some screenshots during the weekend to help us decide.

@Ivan-Brigidano
Copy link
Member Author

As the idea is to make it visible maybe the best place is just at the bottom of the name. What do you think?

@moralsh
Copy link
Contributor

moralsh commented Oct 4, 2019

See for yourself:
Iván Brigidano Pérez _ World Cube Association

The idea is to mirror the colors in the teams-committees page (blue leader, green senior, grey member) ant to link to that team section on that page, I've not decided yet whether to use the short version (WRC Member) or the long one (WCA Regulations Committee member) but of course I'm open to suggestions.

I think I'll code this option first and, see how that looks for people with various roles and then look at other options

@Ivan-Brigidano
Copy link
Member Author

Looks nice to me!
Maybe rectangular labels with rounded corners will match better other label of the website. For example, incidents log labels
Captura de pantalla 2019-10-04 a las 21 59 42

Anyways this looks nice!

@moralsh
Copy link
Contributor

moralsh commented Oct 6, 2019

I'll try when I have time to make a custom label for this, for now I'm sticking with classes we already have.

Some examples here:
JA
apdrf
GB

I'm thinnking also in adding Delegate status.

@Jambrose777
Copy link
Member

+1 for Delegate status as well.

@moralsh
Copy link
Contributor

moralsh commented Oct 7, 2019

new screenshot today:

Screenshot from 2019-10-07 20-37-39

  • Added Delegate tags (Either Senior Delegate, Candidate Delegate or Delegate)
  • Fixed Diferent Size here and on the teams page

As of now, I'm adding every position except WCA Board, because it seems redundant with the officers tags, but would like to hear other opinions, as well as the Board's.

What's left to do:

  • Link to the teams page (with an anchor to the selected team) or delegate page
  • I18n

I'll put together a PR and ask for review as soon as I'm done with it, I fear there's too much code on the view and that I should move some of the logic to the model or controller, I'd like to hear advice from anyone more used to RoR than me (which I guess is almost everybody here)

@Epride
Copy link
Member

Epride commented Oct 8, 2019

Given that not all Board members are necessarily officers I would say having the Board tag would be good.

moralsh added a commit to moralsh/worldcubeassociation.org that referenced this issue Oct 8, 2019
@moralsh
Copy link
Contributor

moralsh commented Oct 8, 2019

Done linking and internationalizing, plus adding a board tag for Board members, I've changed The Member tag by just the acronym of the team, and also added councils, which weren't yesterday.

@moralsh
Copy link
Contributor

moralsh commented Nov 11, 2019

I've been refactoring this (almost done) and would like input in the order the tags are shown, right now is delegate, officers, board, leaders, senior members and members.
I'm as bit unsure as where to place delegates, the rest seems logical.

Anybody wants to share his/her opinion?

@Ivan-Brigidano
Copy link
Member Author

I think placing Delegate status with the rest of the labels might work pretty well

@EdHollingdale
Copy link
Contributor

If we want these labels to be used by competitors to identify who they can speak to, then a label for WCA Delegate is the most important of all in my opinion.

@Ivan-Brigidano
Copy link
Member Author

If we want these labels to be used by competitors to identify who they can speak to, then a label for WCA Delegate is the most important of all in my opinion.

So Delegate labels could appear before Teams labels, for example

@moralsh
Copy link
Contributor

moralsh commented Dec 14, 2019

Just bumping the issue to see if PR #4704 can get merged and this closed :)

@Ivan-Brigidano
Copy link
Member Author

Awesome work, @moralsh 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants