Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle both external and internal policies. #4108

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@AlbertoPdRF
Copy link
Member

commented May 1, 2019

A change is also needed on https://github.com/thewca/wca-documents for this to work!

@jonatanklosko could you review? 馃檪

@jfly
Copy link
Member

left a comment

One question for you, but otherwise LGTM!

AlbertoPdRF added a commit to AlbertoPdRF/wca-documents that referenced this pull request May 1, 2019

@AlbertoPdRF AlbertoPdRF force-pushed the AlbertoPdRF:InternalAndExternalPolicies branch from 0e0fd24 to 761415f May 1, 2019

AlbertoPdRF added a commit to AlbertoPdRF/wca-documents that referenced this pull request May 1, 2019

@jonatanklosko
Copy link
Member

left a comment

LGTM!

@jfly

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Let's coordinate over slack with when to merge this. @AlbertoPdRF , have you put together a corresponding PR for wca-documents yet?

@AlbertoPdRF

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Yes, it's here: thewca/wca-documents#88

It still needs an approving review from someone else from @thewca/board though.

@jfly jfly merged commit e80e7b2 into thewca:master May 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0008%) to 95.849%
Details

jfly added a commit to thewca/wca-documents that referenced this pull request May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.