Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Regional Organizations' application form to the website. #4242

Merged

Conversation

Projects
None yet
2 participants
@AlbertoPdRF
Copy link
Member

commented Jun 22, 2019

With this PR, everything I planned to do regarding Regional Organizations is done 馃槃

@AlbertoPdRF AlbertoPdRF force-pushed the AlbertoPdRF:RegionalOrganizationsApplicationForm branch 2 times, most recently from b92d245 to fb64450 Jun 22, 2019

@AlbertoPdRF

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

I'm having a problem that I noticed after deploying #4183 to production that I can't quite figure out.

  • On development: when a PDF is uploaded, I can preview the first page on the Edit Regional Organization page, and clicking on it I can download it.
  • On production: when a PDF is uploaded, I don't see anything on the Edit Regional Organization page.

I deployed the changes on this PR to the staging server to test the new features, and I still have the same problem as on the production one. Also, I wanted to see how the automatic emails looks like when sent from a production server (as it looks fine on my local server, but I guess it will have the same problem as the Edit Regional Organization page), but I don't know how/if those can be seen someway.

Any ideas?

@AlbertoPdRF AlbertoPdRF force-pushed the AlbertoPdRF:RegionalOrganizationsApplicationForm branch 2 times, most recently from 3260713 to 376fd6a Jul 6, 2019

@AlbertoPdRF

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2019

PDFs still couldn't be previewed on staging with poppler, so I just dropped that commit.

@jonatanklosko
Copy link
Member

left a comment

Great work! A couple comments from me =)

@AlbertoPdRF AlbertoPdRF force-pushed the AlbertoPdRF:RegionalOrganizationsApplicationForm branch from 376fd6a to d8d1026 Jul 8, 2019

@AlbertoPdRF AlbertoPdRF force-pushed the AlbertoPdRF:RegionalOrganizationsApplicationForm branch from d8d1026 to 5de72ac Jul 8, 2019

@jonatanklosko
Copy link
Member

left a comment

LGTM!

@AlbertoPdRF AlbertoPdRF merged commit fc50c10 into thewca:master Jul 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 95.85%
Details

@AlbertoPdRF AlbertoPdRF deleted the AlbertoPdRF:RegionalOrganizationsApplicationForm branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.