Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist public actions in registrations controller #4407

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@jonatanklosko
Copy link
Member

commented Aug 4, 2019

So far we've been explicitly specifying which actions are restricted and that's easy to forget when adding new ones.

@jonatanklosko jonatanklosko force-pushed the jonatanklosko:regs-controller-fix branch from d1c345e to cbaa0d5 Aug 4, 2019

@jfly

jfly approved these changes Aug 4, 2019

Copy link
Member

left a comment

LGTM! This feels safer to me =)

@jonatanklosko jonatanklosko force-pushed the jonatanklosko:regs-controller-fix branch from cbaa0d5 to 589e57a Aug 4, 2019

@jonatanklosko jonatanklosko merged commit 51e71d2 into thewca:master Aug 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AlbertoPdRF

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Should we make this change for the other controllers in the same situation too?

@jonatanklosko

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

I don't think it makes sense for every controller that has any restricted actions. For instance CompetitionsController has a bunch of public actions and it feels more natural to add restrictions (I think). To me RegistrationsController feels kind more like an "admin" one, but maybe it's just me ^^ Happy to hear other opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.