Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create automated assignment for monthly digest #4428

Open
wants to merge 1 commit into
base: master
from

Conversation

@viroulep
Copy link
Member

commented Aug 5, 2019

The topic of the WST monthly digest popped in a discussion, and to try to restore it and avoid managing the chores manually, I'd suggest to pick a (not-new) member at random at the end of each month.
Also I'm definitely fine with ignoring the given assignment if the random is bad (eg: twice the same person in a row, someone really busy at this period); anyone from the WST could cover for the person picked upon request.

Here is how it looks like:
mail

I did not test the cron job!
Any idea how to check it's a valid monthly cron job?

@jonatanklosko
Copy link
Member

left a comment

LGTM! I don't know a good way to test the cron job, but it looks like a monthly one to me ^^

Show resolved Hide resolved WcaOnRails/app/jobs/generate_chore.rb Outdated

@viroulep viroulep force-pushed the viroulep:create-chores branch from 974d924 to 6b296e5 Aug 5, 2019

@jfly

jfly approved these changes Aug 6, 2019

Copy link
Member

left a comment

LGTM


<p>
The monthly digest should contain a summary of the WST work for the past month.
It doesn't need to go into every details, but should definitely mention important changes.

This comment has been minimized.

Copy link
@jfly

jfly Aug 6, 2019

Member

nit: every details -> every detail

def perform
# Randomly select a member who has been there for at least a month
members = Team.wst.current_members.select { |m| m.start_date < 1.month.ago }
ChoreMailer.notify_wst_of_assignee(members.sample.user).deliver_now

This comment has been minimized.

Copy link
@jfly

jfly Aug 6, 2019

Member

I wonder if we could come up with something a little more "fair" than random here... is there some clever "algorithm" we could use that would cycle between team members in a way that wouldn't get screwed up by people coming and going?

I can't actually think of anything right now, but will sleep on it...

This comment has been minimized.

Copy link
@AlbertoPdRF

AlbertoPdRF Aug 14, 2019

Member

Maybe we can go ahead with the random approach for now and manually intervene/change it if we appreciate much unfairness?

@AlbertoPdRF
Copy link
Member

left a comment

Wohoo, this is nice! 🎉

<p>
The monthly digest should contain a summary of the WST work for the past month.
It doesn't need to go into every details, but should definitely mention important changes.
You can definitely group similar changes together, for instance by having only one bullet point for packages and locales updates, since we're having dozen of them every month.

This comment has been minimized.

Copy link
@AlbertoPdRF

AlbertoPdRF Aug 6, 2019

Member

Nit: dozen->dozens

The monthly digest should contain a summary of the WST work for the past month.
It doesn't need to go into every details, but should definitely mention important changes.
You can definitely group similar changes together, for instance by having only one bullet point for packages and locales updates, since we're having dozen of them every month.
If you need some inspiration for writing your email, you can check one of the several monthly digests sent in the past.

This comment has been minimized.

Copy link
@AlbertoPdRF

AlbertoPdRF Aug 6, 2019

Member

Should we instead add a link to a template one?

<li>Try to send the digest on the first few days of next month.</li>
<li>
In your email, be sure to include links to relevant PRs.
We want to encourage curiosity from our delegates, maybe they'll become software team members someday!

This comment has been minimized.

Copy link
@AlbertoPdRF

AlbertoPdRF Aug 6, 2019

Member

delegates should be Staff here 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.