Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP rankings in favor of RoR ones. #4463

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@AlbertoPdRF
Copy link
Member

commented Aug 13, 2019

After having checked that the code from #4394 works on production (see here) it's time to get rid of the old rankings page!

The changes on chef/site-cookbooks/wca/templates/worldcubeassociation.org.conf.erb come from @jonatanklosko (see #4394 (comment),) and the changes from this PR are currently deployed on staging for if someone wants to check them out 馃檪

@jonatanklosko
Copy link
Member

left a comment

LGTM! Still, I'd love if @jfly could have a quick look at the nginx config =)

@AlbertoPdRF AlbertoPdRF force-pushed the AlbertoPdRF:PortRankingsToRails branch from 2b7718e to 408320d Aug 13, 2019

@AlbertoPdRF

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

While playing around on staging I noticed that old links to a region with spaces on it (e.g. South America) are also of the form region=_South%2BAmerica, so I've just added a commit to handle that properly. Everything else seems to work as expected!

@jfly

jfly approved these changes Aug 13, 2019

Copy link
Member

left a comment

LGTM! This is super awesome!

@AlbertoPdRF AlbertoPdRF force-pushed the AlbertoPdRF:PortRankingsToRails branch from a517139 to ac6d1b0 Aug 13, 2019

@AlbertoPdRF

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Thanks for the reviews! I'll merge this one when tests pass 馃槃

@AlbertoPdRF AlbertoPdRF merged commit 1dc5eca into thewca:master Aug 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AlbertoPdRF AlbertoPdRF deleted the AlbertoPdRF:PortRankingsToRails branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.