Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualify mysql 8.0 reserved keyword rank in PHP code #4570

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@tussosedan
Copy link
Contributor

commented Sep 2, 2019

Following up on #4522, this prepares the SQL statements in the PHP code for upgrade to mysql 8.0.

@jonatanklosko
Copy link
Member

left a comment

LGTM! Will wait for someone to double-check as it's the PHP stuff ^^ (@jfly?)

event.rank,
competition.year,
competition.month,
competition.day

This comment has been minimized.

Copy link
@jonatanklosko

jonatanklosko Sep 2, 2019

Member

Nit: just to follow the convention used here, please align these to the left.

This comment has been minimized.

Copy link
@tussosedan

tussosedan Sep 2, 2019

Author Contributor

I actually tried following the convention here for columns with aliases vs the original column names
image

This comment has been minimized.

Copy link
@jonatanklosko

jonatanklosko Sep 2, 2019

Member

Ah! That looks weird, but let's leave it like that then ^^

@jfly

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

LGTM! I'll go ahead and deploy this to staging now.

Thanks, @tussosedan!

@jfly jfly merged commit ab27f2e into thewca:master Sep 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.962%
Details
@jfly

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Err, whoops, I merged this to master. I guess we're going straight to prod =)

@tussosedan tussosedan deleted the tussosedan:qualify-rank-keyword branch Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.