Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved errors in results #4978

Merged
merged 2 commits into from Jan 7, 2020
Merged

Improved errors in results #4978

merged 2 commits into from Jan 7, 2020

Conversation

@viroulep
Copy link
Member

viroulep commented Dec 18, 2019

Fixes #4638, fixes #4964.

  • Allow for null pos in the json, and validate it in the model
  • Check for skip/dns only results
  - Allow for null pos in the json, and validate it in the model
  - Check for skip/dns only results
@viroulep viroulep force-pushed the viroulep:improved-errors branch from 9994231 to 8cd379f Dec 18, 2019
@viroulep viroulep force-pushed the viroulep:improved-errors branch from d87b1fd to f7dd81e Dec 19, 2019
@viroulep

This comment has been minimized.

Copy link
Member Author

viroulep commented Jan 5, 2020

Will merge tomorrow unless someone reviews or intends to review by then.

Copy link
Member

jonatanklosko left a comment

LGTM, thanks for improving that!

@viroulep viroulep merged commit b43e412 into thewca:master Jan 7, 2020
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.004%) to 96.111%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@viroulep viroulep deleted the viroulep:improved-errors branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.