Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trophy icon to championships in the my_competitions tables #5043

Merged
merged 3 commits into from Jan 11, 2020

Conversation

@AxelFl
Copy link
Contributor

AxelFl commented Jan 11, 2020

Issue #4508
Places the trophy icon to the right of the names of championships in the my competitions view
Also has the tooltip indicating the type of championship

Copy link
Member

jonatanklosko left a comment

Hey, thanks for your contribution! The code LGTM, could you please add an example screenshot? =)

@jonatanklosko

This comment has been minimized.

Copy link
Member

jonatanklosko commented Jan 11, 2020

Also note that some tests are failing, specifically this and this.
My guess would be that whitespaces cause the problem, I think it's fine to not assert the whole html tags, but just competition names. Let me know if you have any troubles with that!

@AxelFl

This comment has been minimized.

Copy link
Contributor Author

AxelFl commented Jan 11, 2020

Screenshot from 2020-01-11 17-20-06
Screenshot from 2020-01-11 14-59-56
Screenshot from 2020-01-11 15-02-39
Screenshot from 2020-01-11 15-03-11

How it looks in the menu.

I removed the tags around the tests since they are on new lines after the change. But it still checks the name and working link.
Maybe there should be a test for championships now as well?

@jonatanklosko

This comment has been minimized.

Copy link
Member

jonatanklosko commented Jan 11, 2020

Perfect, thanks!

Maybe there should be a test for championships now as well?

If you feel like adding one, I'm all for it =)

@AxelFl AxelFl force-pushed the AxelFl:master branch from b74427a to 39605cb Jan 11, 2020
@jonatanklosko

This comment has been minimized.

Copy link
Member

jonatanklosko commented Jan 11, 2020

Thanks a lot!

@jonatanklosko jonatanklosko merged commit f0c6328 into thewca:master Jan 11, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 96.238%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.